Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce mgit save-hashes command #27

Closed
pjasiun opened this issue Jan 22, 2017 · 5 comments
Closed

Introduce mgit save-hashes command #27

pjasiun opened this issue Jan 22, 2017 · 5 comments

Comments

@pjasiun
Copy link

pjasiun commented Jan 22, 2017

mgit update set versions in packages folder to the versions defined in mgit.json file. But the opposite command would be also needed, to set versions in mgit.json to hashes in the packages.

I propose the mgit save-hashes command which goes into each repository check the current hash and add #hash to each entry in mgit.json. It's very useful if the project uses fixed versions of dependencies and update them manually.

@pomek
Copy link
Member

pomek commented Jan 23, 2017

It can be also helpful for the tool for saving revisions in CKE5.

At this moment, we have to do it manually - https://github.com/ckeditor/ckeditor5-dev/blob/t/ckeditor5-revisions/1/packages/ckeditor5-dev-env/bin/save-revision.js.

@pomek
Copy link
Member

pomek commented Jan 23, 2017

Looks like work as I expected: ckeditor/ckeditor5@b55508d

@pomek
Copy link
Member

pomek commented Jan 31, 2017

I would call this command dump because this reminds me with the database dump.

@Reinmar
Copy link
Member

Reinmar commented Jan 31, 2017

Turns out I wanted to name it exactly like PJ proposed: #38 (comment) ;) So better to stick to that.

@pomek
Copy link
Member

pomek commented Jan 31, 2017

Ok…

image

Reinmar added a commit that referenced this issue Jan 31, 2017
Feature: Introduced "save-hashes" command for saving hashes of the packages. Resolves: #27.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants