Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TensorTools Randomize Functions could be CUDAfied #438

Closed
neubig opened this issue Apr 12, 2017 · 2 comments
Closed

TensorTools Randomize Functions could be CUDAfied #438

neubig opened this issue Apr 12, 2017 · 2 comments
Labels
enhancement

Comments

@neubig
Copy link
Contributor

neubig commented Apr 12, 2017

Currently generating random numbers is done on the CPU and these random numbers are transferred to the GPU. It would be nice if we could generate random numbers directly on the GPU as it would presumably be much faster. (The GPU random seed would also need to be set with dynet-seed to ensure consistency across runs.)
@neubig
Copy link
Contributor Author

neubig commented Apr 12, 2017

This can likely be done through Eigen tensor's random number generation capability. See eigen/unsupported/test/cxx11_tensor_random.cc and eigen/unsupported/test/cxx11_tensor_random_cuda.cu for details.

@neubig neubig mentioned this issue Apr 13, 2017
Closed
@pmichel31415 pmichel31415 mentioned this issue May 15, 2017
Closed
@msperber msperber mentioned this issue Nov 24, 2017
Closed
2 tasks
@neubig neubig mentioned this issue Dec 22, 2017
Merged
@neubig
Copy link
Contributor Author

neubig commented Feb 9, 2018

Done by #1154.

@neubig neubig closed this as completed Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neubig