Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structures are randomized in the same way #43

Open
connorkuehl opened this issue Mar 11, 2019 · 4 comments
Open

Structures are randomized in the same way #43

connorkuehl opened this issue Mar 11, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@connorkuehl
Copy link

This is because the Randstruct object is created and destroyed with each structure.

Kees suggested we use the structure name as part of the seed.

@connorkuehl connorkuehl added the bug Something isn't working label Mar 11, 2019
@jcantrell
Copy link

Just to clarify, does this mean that, say, structures with three members will be shuffled into the same order as all other structures with three members?

@connorkuehl
Copy link
Author

Just to clarify, does this mean that, say, structures with three members will be shuffled into the same order as all other structures with three members?

I think so, yes

@tim-pugh
Copy link
Member

+1 on using the struct name. This will ensure the same named structs are randomized in a predictable fashion, but structs with the same count of fields will differ.

@tim-pugh
Copy link
Member

We also have another issue brought up by the clang devs whom are reviewing our code where the default random engine may, from my understanding, use different engines, so we would need to choose a specific random algorithm.

I believe this should take care of randomness issues against platforms. View #44 which this issue depends upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants