New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label "close" commands for views; improve enablement #531

Merged

HighCommander4 merged 1 commit into clangd:master from colin-grant-work:feature/better-close-commands

Sep 19, 2023

Contributor

colin-grant-work commented Sep 14, 2023

At the moment, the Close commands for each contributed view:

All have the same title "Close"
Are all enabled and visible in the command palette even if the corresponding view isn't actually visible

This PR

Adds details about the view to be closed to the title so that each is distinct
Uses a ${viewId}.visible context key that is automatically set up by VSCode for each view to determine enablement.


          Label Close commands for views; improve enablement

dddd6ed

HighCommander4 approved these changes

View reviewed changes

Contributor

HighCommander4 left a comment

Thanks!

HighCommander4 merged commit b1113ec into clangd:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet