Can't unset a global setting

[anna-is-cute]

Affected Version of clap

2.29.4

Expected Behavior Summary

Unsetting a setting that has been made global causes it to not affect the arg or subcommand.

Actual Behavior Summary

The setting still applies.

Sample Code or Link to Sample Code

extern crate clap;

use clap::{App, Arg, SubCommand, AppSettings};

fn main() {
  let args = App::new("app")
    .global_setting(AppSettings::ArgRequiredElseHelp)
    .arg(Arg::with_name("arg1")
      .takes_value(true)
      .multiple(false)
      .required(false))
    .subcommand(SubCommand::with_name("sub")
      .unset_setting(AppSettings::ArgRequiredElseHelp)
      .arg(Arg::with_name("arg2")
        .takes_value(true)
        .multiple(false)
        .required(false)))
    .get_matches();
  println!("{:#?}", args);
}

In the subcommand, the only arg is optional, so I don't want ArgRequiredElseHelp, but the vast majority of other subcommands (in my use case) all benefit from ArgRequiredElseHelp.

I can see this is because it's unset in settings but not g_settings. Should unset_setting do both or should unset_global_setting be added? I'd be happy to PR if I knew which direction to go in.

[kbknapp]

You're spot on, and actually in v3 I side step this slightly by using (un)set and (un)set_global and actually differentiating the two. For v2 I think it's going to have to stay as is, because I fear changing it would be breaking change (i.e. if there are people relying the current behaviour).

I'm going to close this, however when v3 is released if this issue pops up please feel free to re-address it.