v3 Prep #1154
Merged
v3 Prep #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p::write_help Contains a *MINOR* breaking change. App::write_help now requires `&mut self` instead of `&self`. This fixes a major bug where the help message is entirely incorrect. More can be found at #808 I've decided to make this change because it was preventing further progress. Anyone's code who breaks the fix is trivial: ```rust // OLD BROKEN let app = App::new("broken"); let mut out = io::stdout(); app.write_help(&mut out).expect("failed to write to stdout"); // NEW FIX let mut app = App::new("broken"); // <-- let mut let mut out = io::stdout(); app.write_help(&mut out).expect("failed to write to stdout"); ``` Closes #808
This commit primarily changes to a lazy handling of POSIX overrides by relying on github.com/bluss/ordermap instead of the old HashMap impl. The ordermap allows us to keep track of which arguments arrived first, and therefore determine which ones should be removed when an override conflict is found. This has the added benefit of we no longer have to do the bookkeeping to keep track and override args as they come in, we can do it once at the end. Finally, ordermap allows fast Vec like iteration of the keys, which we end up doing several times. Benching is still TBD once the v3 prep is done, but this change should have a meaningful impact.
2 tasks
epage
added a commit
to epage/clap
that referenced
this pull request
Dec 27, 2021
This allows two overriding args to interact with each other mid-line. This was broken in 7673dfc / clap-rs#1154. Before that, we duplicated the override logic in severla places. Now we plug into the start of a new arg which allows us to do this incrementally without making the logic complex or inefficient, thanks to prior refactors. Fixes clap-rs#3217
epage
added a commit
to epage/clap
that referenced
this pull request
Dec 27, 2021
This allows two overriding args to interact with each other mid-line. This was broken in 7673dfc / clap-rs#1154. Before that, we duplicated the override logic in several places. Now we plug into the start of a new arg which allows us to do this incrementally without making the logic complex or inefficient, thanks to prior refactors. Fixes clap-rs#3217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the stage for v3.
The old v3-master became too far behind v2, and backporting all the bug fixes and features was a little too difficult with my limited time. So this is a fresh start. This time I'm going to feature freeze v2 until v3 is out.
It contains all the ground work to start implementing actual deprecations, breaking changes, and new features. See #1037 for details on whats left to do (...TONS right now).
This change is