Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show arg/command descriptions in dynamic completions #5056

Merged
merged 5 commits into from
Aug 7, 2023
Merged

Show arg/command descriptions in dynamic completions #5056

merged 5 commits into from
Aug 7, 2023

Conversation

ModProg
Copy link
Contributor

@ModProg ModProg commented Jul 31, 2023

based on #5048

@epage epage changed the title dynamic completions help Show arg/command descriptions in dynamic completions Jul 31, 2023
@ModProg ModProg mentioned this pull request Jul 31, 2023
Open
2 tasks
@epage epage mentioned this pull request Jul 31, 2023
Closed
@ModProg
Copy link
Contributor Author

ModProg commented Jul 31, 2023

the dedup thing seams to be a rust-analyzer bug.

@ModProg
Copy link
Contributor Author

ModProg commented Aug 3, 2023

It would be nice if the snapshots from the completion output were snapshot files as well, would make updating easier.

@epage
Copy link
Member

epage commented Aug 3, 2023

It would be nice if the snapshots from the completion output were snapshot files as well, would make updating easier.

I'm hoping to one day support in-code snapshot updating

Also, most tests should be on the shell-agnostic code. The shell-specific code should mostly be tested to ensure shell integration works

@ModProg ModProg requested a review from epage August 7, 2023 07:29
@epage
Copy link
Member

epage commented Aug 7, 2023

Thanks for all of your work on this!

@epage epage merged commit fe04b3c into clap-rs:master Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage Awaiting requested review from epage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ModProg @epage