Use try!() instead of ? operator, for older compilers #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
appveyor failed because of a (?) compiler bug? |
|
It seems to be removed in 7cb44ab as well, but the |
|
Ah yep that one was just missed when I was fixing merge conflicts from the earlier revert! Thanks for catching it! @homu r+ |
|
📌 Commit 62e6a1e has been approved by |
homu
added a commit
that referenced
this pull request
Nov 16, 2016
Use try!() instead of ? operator, for older compilers This is a proposal. Some distros (yes, I'm using the distro rustc because my distro has some benefits over using the rustup infrastructure) do not yet have the newest compiler. I therefor propose to stay with `try!()` instead of `?` for maybe two weeks or so, maybe even a bit more, until all distros have updated their version of `rustc`.
homu
added a commit
that referenced
this pull request
Nov 16, 2016
Use try!() instead of ? operator, for older compilers This is a proposal. Some distros (yes, I'm using the distro rustc because my distro has some benefits over using the rustup infrastructure) do not yet have the newest compiler. I therefor propose to stay with `try!()` instead of `?` for maybe two weeks or so, maybe even a bit more, until all distros have updated their version of `rustc`.
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 62e6a1e has been approved by |
|
☀️ Test successful - status |
|
👀 Test was successful, but fast-forwarding failed: 422 Required status check "coverage/coveralls" is pending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal.
Some distros (yes, I'm using the distro rustc because my distro has some benefits over using the rustup infrastructure) do not yet have the newest compiler.
I therefor propose to stay with
try!()instead of?for maybe two weeks or so, maybe even a bit more, until all distros have updated their version ofrustc.