Skip to content
This repository has been archived by the owner on Jul 25, 2021. It is now read-only.

ignoreCSS Selectors Do NOT Work Dynamically without Calling table.reset() #144

Closed
own3mall opened this issue Aug 6, 2018 · 3 comments
Closed

Comments

@own3mall
Copy link

own3mall commented Aug 6, 2018

I'm using the latest version of TableExport v5 with jQuery 3.x.

When using the below ignoreCSS setting, if I dynamically add or remove the defined classes to specific <th> and <td> columns, the columns are not ignored properly unless I call table.reset() after adding or removing these classes using a toggle column control I created. I would assume that when the export function is called, it should recheck all the columns again without me having to reset anything and determine whether or not it should be ignored based on its classname.

TableExport.prototype.ignoreCSS = [".hide", ".noExcel"];
@dagang007
Copy link

Hi ! Do you know where to set datetime format ? My question is just beside yours ( No.69 )

@clarketm
Copy link
Owner

clarketm commented Oct 24, 2018

@own3mall – the parsing process is a rather heavy, high processing-time operation since, on the client-side, it must parse arbitrarily large tables in up 4 different file formats. For this reason, the parsed output is generated one time on the execution of TableExport and does not dynamically update unless explicitly told to with a call to reset. Unfortunately, unlike React there is no diff algorithm to detect changes in TableExport.

I would be more than open to adding a robust diff algorithm to detect mutations but at the moment this is not available.

@own3mall
Copy link
Author

Ok, no problem. Thanks for looking into it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants