Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clash-lib: Print constructor names in netlist errors #2633

Merged
merged 1 commit into from
Jan 18, 2024
Merged

clash-lib: Print constructor names in netlist errors #2633

merged 1 commit into from
Jan 18, 2024

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Dec 30, 2023

While debugging a netlist generation failure I found this output to be useful.

martijnbastiaan
martijnbastiaan approved these changes Jan 14, 2024
View reviewed changes
Copy link
Member

@martijnbastiaan martijnbastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense to me. Could you rebase? I think something went wrong in the release process, so you might need to cherry-pick:

git fetch
git reset origin/master --hard
git cherry-pick b9177138e3e6a8a9e507ae031210c6cef5f6e9ac
git push -f

@bgamari bgamari force-pushed the wip/netlist-errors branch from b917713 to c54880d Compare January 15, 2024 23:53
@bgamari
Copy link
Contributor Author

bgamari commented Jan 15, 2024

Rebased.

@martijnbastiaan
Copy link
Member

CI doesn't pass because of warnings - you probably want to mention nm in the various error messages. Could you fix them?

@bgamari bgamari force-pushed the wip/netlist-errors branch from c54880d to db3f9d9 Compare January 18, 2024 17:32
@bgamari
Copy link
Contributor Author

bgamari commented Jan 18, 2024

Oh dear, indeed what a mess. I rather don't need to bind nm at all as I belive dcNm is sufficient for our purposes.

@martijnbastiaan
Copy link
Member

@kloonbot run_ci db3f9d9

@martijnbastiaan martijnbastiaan enabled auto-merge (squash) January 18, 2024 20:23
@martijnbastiaan martijnbastiaan merged commit 5e01ae2 into clash-lang:master Jan 18, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Jan 18, 2024
@bgamari @mergify
clash-lib: Print constructor names in netlist errors (#2633)
0491c92 
(cherry picked from commit 5e01ae2)
@mergify mergify bot mentioned this pull request Jan 18, 2024
Merged
martijnbastiaan pushed a commit that referenced this pull request Jan 19, 2024
@mergify @bgamari
clash-lib: Print constructor names in netlist errors (#2633) (#2647)
2e48bf9 
(cherry picked from commit 5e01ae2)

Co-authored-by: Ben Gamari <ben@smart-cactus.org>
hiddemoll pushed a commit that referenced this pull request Feb 1, 2024
@bgamari @hiddemoll
clash-lib: Print constructor names in netlist errors (#2633)
f3cc08d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnbastiaan martijnbastiaan martijnbastiaan approved these changes

Assignees
No one assigned
Labels
backport 1.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgamari @martijnbastiaan