Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we don't handle char-downcase or char-upcase for unicode chars correctly #1120

Closed
kpoeck opened this issue Dec 27, 2020 · 3 comments
Closed
Assignees
Labels

Comments

@kpoeck
Copy link
Contributor

kpoeck commented Dec 27, 2020

as Bike notes in #164

(char-downcase #\CYRILLIC_CAPITAL_LETTER_IE_WITH_GRAVE)
-> #\CYRILLIC_CAPITAL_LETTER_IE_WITH_GRAVE
@kpoeck kpoeck self-assigned this Dec 27, 2020
@kpoeck
Copy link
Contributor Author

kpoeck commented Dec 27, 2020

In https://en.cppreference.com/w/cpp/locale/tolower and https://en.cppreference.com/w/cpp/locale/toupper are examples that should work.

This works in Xcode, so lets try this for clasp

@kpoeck
Copy link
Contributor Author

kpoeck commented Dec 27, 2020

seems to work fine:

COMMON-LISP-USER> (char-downcase #\CYRILLIC_CAPITAL_LETTER_IE_WITH_GRAVE)
#\CYRILLIC_SMALL_LETTER_IE_WITH_GRAVE
COMMON-LISP-USER> (char-upcase #\CYRILLIC_SMALL_LETTER_IE_WITH_GRAVE)
#\CYRILLIC_CAPITAL_LETTER_IE_WITH_GRAVE

@kpoeck
Copy link
Contributor Author

kpoeck commented Jan 9, 2021

Works now fine with pr #1121 merged

@kpoeck kpoeck closed this as completed Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants