Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange string code to support displaced strings and prepare for Unicode #179

Closed
drmeister opened this issue Nov 25, 2015 · 4 comments
Closed

Comments

@drmeister
Copy link
Collaborator

Currently only 8bit-character strings are supported. Code needs to be moved out of str.cc into lispString.cc and generalized somewhat to support new types of strings like 16 bit character, and Unicode.

There is also a bug that there is no displaced string type and so (make-array 2 :element-type 'character :displaced-to "abcdefg") doesn't work -

@dkochmanski
Copy link
Contributor

dkochmanski commented Sep 1, 2016

As a temporary solution you may make character being the same type as base-char (ECL does that for builds without unicode) – this would fix this error

@Shinmera
Copy link
Contributor

Shinmera commented Sep 1, 2016

I think that's already the case.

dkochmanski added a commit to dkochmanski/clasp that referenced this issue Sep 2, 2016
drmeister pushed a commit that referenced this issue Sep 2, 2016
@kpoeck
Copy link
Contributor

kpoeck commented May 8, 2019

(make-array 2 :element-type 'base-char :displaced-to "abcdefg") -> "ab"

@Bike
Copy link
Member

Bike commented Dec 11, 2019

we now have displaced arrays and at least in large part have unicode strings, so I'm going to close this. Further unicode issues can be thrown in to #164

@Bike Bike closed this as completed Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants