Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size differences between fonts.google.com version #4

Closed
m4rc1e opened this issue Jul 10, 2017 · 4 comments
Closed

Size differences between fonts.google.com version #4

m4rc1e opened this issue Jul 10, 2017 · 4 comments

Comments

@m4rc1e
Copy link
Contributor

m4rc1e commented Jul 10, 2017

left: this repo | right: fonts.google.com version
screen shot 2017-07-10 at 11 17 03

Seems the upms are different, this repo 1240 | fonts.google.com 2048

I think we need to retain the same scale for the fonts.google.com version, even if its an error. Users will now be used to this scale. I suggest we add a gen_gf_version.py script so we can create a set fonts for gf which keeps the scaling.

This came about whilst trying to solve, google/fonts#7

cc @davelab6

@davelab6
Copy link
Contributor

davelab6 commented Jul 10, 2017 via email

@clauseggers
Copy link
Owner

clauseggers commented Jul 10, 2017

I don’t remember why the UPM has changed, but it was probably done to comply to webfont compatible vertical metrics. I feel we had a discussion about Playfair vertical metrics before, and this was the outcome.

@m4rc1e
Copy link
Contributor Author

m4rc1e commented Nov 2, 2017

Solved, a script to generate the GF version has been included in the sources dir.

@m4rc1e m4rc1e closed this as completed Nov 2, 2017
@RuixiZhang42
Copy link

RuixiZhang42 commented Jun 21, 2019

@clauseggers Hi Claus! I was wondering if the letterforms were actually designed at 1000 UPMs. When using the fonts from this repo, I found the font size “appeared” way too small. For example, the cap height, based on 1240 UPMs, is merely 708/1240 = 57% in the regular weight. As a result, I had to use about 120% of the previous point size in my headings to get Playfair Display to “appear just big enough”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants