Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.8.7 Compatibility #2

Open
phillbaker opened this issue Nov 6, 2013 · 1 comment
Open

1.8.7 Compatibility #2

phillbaker opened this issue Nov 6, 2013 · 1 comment

Comments

@phillbaker
Copy link

I know 1.8.7 is on it's way out, but define_singleton_method in looks like the only thing making this gem incompatible with 1.8.7.

Any chance of accepting a pull request that replaces define_singleton_method? (intercom/intercom-rails#31 would be a similar example of a replacement.)
@clbustos
Copy link
Owner

clbustos commented Mar 6, 2014

Personally, I don't have any problem on create the method on-the-fly for 1.8.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phillbaker @clbustos