Add chrome 86 Dart DDC workaround #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxwellpeterson-wf
approved these changes
Oct 5, 2020
greglittlefield-wf
approved these changes
Oct 5, 2020
corwinsheahan-wf
commented
Oct 5, 2020
maxwellpeterson-wf
approved these changes
Oct 5, 2020
greglittlefield-wf
force-pushed
the
add_chrome_86_workaround
branch
from
20845cb to
0703ea5
Compare
QA +1 Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome 86 introduces a bug in DDC for dart versions <2.9.3
There is an easy workaround to this by adding a small script to the page.
This pr introduces that workaround in the dev react js files in this package for convenience.