CPLAT-12688 Add synthetic Event Utils to master #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joebingham-wk
changed the title
|
For CI, Dart 2.10.x fails on the formatting step - my understanding is that this was known and ignored for now. Let me know if there is something to do there though! |
greglittlefield-wf
requested changes
Nov 6, 2020
greglittlefield-wf
approved these changes
Nov 6, 2020
|
QA+1 Everything looks great!
|
|
Verified CI failed due to that same Dart 2.10.x formatting step! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare for React 17, there needs to be APIs that abstract the creation of SyntheticEvents so that we can remove dependence on the event class constructors.
Changes
createSynthetic{eventClass}function for every synthetic event type that allows consumers to create an empty instance, set specific properties on an instance, or merge an instance with new propertiesQA