Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file paths parsing not consistent #27

Closed
nashmit opened this issue Jul 8, 2022 · 3 comments
Closed

file paths parsing not consistent #27

nashmit opened this issue Jul 8, 2022 · 3 comments

Comments

@nashmit
Copy link

nashmit commented Jul 8, 2022

Currently, this project works well under Linux but not under Windows.

This is due to the fact that the separators are mixed into the parsing process. If the urdf file contains Linux separators "/" to define paths one will end up mixing Linux sep. with windows since in the current implementation os.path.sep is used, which in this case it's going to return \\.

Can you advise an easy fix at this point?

@clemense
Copy link
Owner

clemense commented Jul 8, 2022

Thanks for reporting! As far as I understand I assume a file name prefix like package:// would look like package:\\ in Windows which is not the case, right? (I couldn't find any information on this). I will create a fix for this.

@clemense
Copy link
Owner

clemense commented Jul 8, 2022

Ok, I hope this fixes it. It's now in version 0.0.51. Please re-open if this still occurs.

@clemense clemense closed this as completed Jul 8, 2022
@nashmit
Copy link
Author

nashmit commented Jul 9, 2022

Thanks for taking care of it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants