From b4868ab8fdb84144d2016b49e67e7fdd2c348316 Mon Sep 17 00:00:00 2001
From: Clerk Cookie <136073014+clerk-cookie@users.noreply.github.com>
Date: Wed, 13 Dec 2023 10:43:31 +0200
Subject: [PATCH] chore(clerk-js): Update zxcvbn dependency (#2326) (#2332)

* chore(clerk-js): Update zxcvbn dependency

* chore(repo): Add changesets

(cherry picked from commit 69ce3e185b89283956cb711629bc61703166b1c9)

Co-authored-by: Lennart <lekoarts@gmail.com>
---
 .changeset/angry-clocks-attend.md  |  5 +++++
 .changeset/long-dancers-whisper.md |  5 +++++
 package-lock.json                  | 14 ++++++++------
 packages/clerk-js/package.json     |  4 ++--
 packages/types/src/passwords.ts    |  2 +-
 5 files changed, 21 insertions(+), 9 deletions(-)
 create mode 100644 .changeset/angry-clocks-attend.md
 create mode 100644 .changeset/long-dancers-whisper.md

diff --git a/.changeset/angry-clocks-attend.md b/.changeset/angry-clocks-attend.md
new file mode 100644
index 0000000000..5b83cab47f
--- /dev/null
+++ b/.changeset/angry-clocks-attend.md
@@ -0,0 +1,5 @@
+---
+'@clerk/clerk-js': patch
+---
+
+Update `@zxcvbn-ts/core` from `2.2.1` to `3.0.4`. Update `@zxcvbn-ts/language-common` from `3.0.2` to `3.0.4`.
diff --git a/.changeset/long-dancers-whisper.md b/.changeset/long-dancers-whisper.md
new file mode 100644
index 0000000000..15a02f2067
--- /dev/null
+++ b/.changeset/long-dancers-whisper.md
@@ -0,0 +1,5 @@
+---
+'@clerk/types': patch
+---
+
+Adjust `ZxcvbnResult` interface to use current `feedback.warning` type as used in the upstream `@zxcvbn-ts/core` library.
diff --git a/package-lock.json b/package-lock.json
index d3468fc265..9fd425886f 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -9933,15 +9933,17 @@
       "license": "Apache-2.0"
     },
     "node_modules/@zxcvbn-ts/core": {
-      "version": "2.2.1",
-      "license": "MIT",
+      "version": "3.0.4",
+      "resolved": "https://registry.npmjs.org/@zxcvbn-ts/core/-/core-3.0.4.tgz",
+      "integrity": "sha512-aQeiT0F09FuJaAqNrxynlAwZ2mW/1MdXakKWNmGM1Qp/VaY6CnB/GfnMS2T8gB2231Esp1/maCWd8vTG4OuShw==",
       "dependencies": {
         "fastest-levenshtein": "1.0.16"
       }
     },
     "node_modules/@zxcvbn-ts/language-common": {
-      "version": "3.0.2",
-      "license": "MIT"
+      "version": "3.0.4",
+      "resolved": "https://registry.npmjs.org/@zxcvbn-ts/language-common/-/language-common-3.0.4.tgz",
+      "integrity": "sha512-viSNNnRYtc7ULXzxrQIVUNwHAPSXRtoIwy/Tq4XQQdIknBzw4vz36lQLF6mvhMlTIlpjoN/Z1GFu/fwiAlUSsw=="
     },
     "node_modules/abab": {
       "version": "2.0.6",
@@ -33531,8 +33533,8 @@
         "@emotion/cache": "11.11.0",
         "@emotion/react": "11.11.1",
         "@floating-ui/react": "0.25.4",
-        "@zxcvbn-ts/core": "2.2.1",
-        "@zxcvbn-ts/language-common": "3.0.2",
+        "@zxcvbn-ts/core": "3.0.4",
+        "@zxcvbn-ts/language-common": "3.0.4",
         "browser-tabs-lock": "1.2.15",
         "copy-to-clipboard": "3.3.3",
         "core-js": "3.26.1",
diff --git a/packages/clerk-js/package.json b/packages/clerk-js/package.json
index 6a22bd440d..bedd9a3f0f 100644
--- a/packages/clerk-js/package.json
+++ b/packages/clerk-js/package.json
@@ -56,8 +56,8 @@
     "@emotion/cache": "11.11.0",
     "@emotion/react": "11.11.1",
     "@floating-ui/react": "0.25.4",
-    "@zxcvbn-ts/core": "2.2.1",
-    "@zxcvbn-ts/language-common": "3.0.2",
+    "@zxcvbn-ts/core": "3.0.4",
+    "@zxcvbn-ts/language-common": "3.0.4",
     "browser-tabs-lock": "1.2.15",
     "copy-to-clipboard": "3.3.3",
     "core-js": "3.26.1",
diff --git a/packages/types/src/passwords.ts b/packages/types/src/passwords.ts
index 831f032671..da984f61dc 100644
--- a/packages/types/src/passwords.ts
+++ b/packages/types/src/passwords.ts
@@ -2,7 +2,7 @@ import type { PasswordSettingsData } from './userSettings';
 
 export interface ZxcvbnResult {
   feedback: {
-    warning: string;
+    warning: string | null;
     suggestions: string[];
   };
   score: 0 | 1 | 2 | 3 | 4;