Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New update appending port to url, breaking production. #1413

Closed
KevinEdry opened this issue Jun 25, 2023 · 4 comments
Closed

New update appending port to url, breaking production. #1413

KevinEdry opened this issue Jun 25, 2023 · 4 comments
Assignees
@dimkl

Comments

@KevinEdry
Copy link

KevinEdry commented Jun 25, 2023 •
edited
Loading 

          This line basically adds to all urls `:80` and breaks them.

Originally posted by @KevinEdry in #1394 (comment)

This basically breaks my app both in development and production, with the exception of localhost, I don't see a reason for appending a port to the url.
@KevinEdry KevinEdry changed the title This line basically adds to all urls :80 and breaks them. New update appending port to url, breaking production. Jun 25, 2023
@dimkl dimkl self-assigned this Jun 26, 2023
dimkl added a commit that referenced this issue Jun 26, 2023
@dimkl
fix(nextjs): Avoid setting clerkUrl port for http(s) if protocol is set
0490217 
Issue: #1413
PR introducing issue: #1394
@dimkl dimkl mentioned this issue Jun 26, 2023
Merged
22 tasks
dimkl added a commit that referenced this issue Jun 26, 2023
@dimkl
fix(nextjs): Avoid setting clerkUrl port for http(s) if protocol is set
11b9198 
Issue: #1413
PR introducing issue: #1394
@dimkl dimkl mentioned this issue Jun 26, 2023
Closed
5 tasks
dimkl added a commit that referenced this issue Jun 26, 2023
@dimkl
fix(nextjs): Avoid setting clerkUrl port for http(s) if protocol is set
3f7b6c5 
Issue: #1413
PR introducing issue: #1394
dimkl added a commit that referenced this issue Jun 27, 2023
@dimkl
fix(nextjs): Avoid setting clerkUrl port for http(s) if protocol is set
a17c43b 
Issue: #1413
PR introducing issue: #1394
dimkl added a commit that referenced this issue Jun 27, 2023
@dimkl
fix(nextjs): Avoid setting clerkUrl port for http(s) if protocol is set
15bd1a5 
Issue: #1413
PR introducing issue: #1394
dimkl added a commit that referenced this issue Jun 27, 2023
@dimkl
fix(nextjs): Avoid setting clerkUrl port for http(s) if protocol is set
7045f6f 
Issue: #1413
PR introducing issue: #1394
@KevinEdry
Copy link
Author

@dimkl Awesome to see a fix so quickly, I am glad to have been of some help! 👍.
I'll close this issue once #1415 will be merged and a new version of @clerk/nextjs is released.

@dimkl
Copy link
Contributor

dimkl commented Jun 28, 2023

Fix released in version @clerk/nextjs@4.21.11.
@KevinEdry could you verify that version and close this issue? :)

@KevinEdry
Copy link
Author

@dimkl Can confirm this fixes the issue, thanks for the help!
Closing this issue for now.

mikestopcontinues pushed a commit to mikestopcontinues/clerk-javascript that referenced this issue Jun 28, 2023
@dimkl @mikestopcontinues
fix(nextjs): Avoid setting clerkUrl port for http(s) if protocol is set
513d520 
Issue: clerk#1413
PR introducing issue: clerk#1394
@clerk-cookie
Copy link
Collaborator

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dimkl dimkl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dimkl @KevinEdry @clerk-cookie