ClerkExpressRequireAuth doesn't have any argument types #1938
Assignees
Labels
prioritized
This issue has been triaged and the team is working on it
Comments
dimkl
added a commit
that referenced
this issue
Oct 25, 2023
24 tasks
dimkl
added a commit
that referenced
this issue
Oct 25, 2023
LekoArts
pushed a commit
that referenced
this issue
Oct 26, 2023
dimkl
added a commit
that referenced
this issue
Oct 30, 2023
dimkl
added a commit
that referenced
this issue
Oct 30, 2023
jescalan
added
prioritized
panteliselef
pushed a commit
that referenced
this issue
Oct 30, 2023
octoper
pushed a commit
that referenced
this issue
Oct 31, 2023
dimkl
added a commit
that referenced
this issue
Oct 31, 2023
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 31, 2023
* fix(clerk-sdk-node): Fix types of ClerkExpressWithAuth/ClerkExpressRequireAuth args (#1939) #1938 * fix(backend): Support NextJS 14 (#1948) * fix(backend): Fix for next 14 fetch bind issue * fix(nextjs): Use named imports for fetch runtime polyfill Next14 seems to have changed the way it handles default exports when using the webpack bundler for some of their build variants when using `npm run dev`. This commit ensures that we no longer use the default export in an effort to improve compat between the different nextjs versions. More information can be found here: https://esbuild.github.io/content-types/#default-interop and here: #612 * Create late-dolphins-peel.md --------- Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com> --------- Co-authored-by: George Desipris <73396808+desiprisg@users.noreply.github.com> Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
|
Is this fixed? It seems fixed, but is not closed. |
|
This was fixed by #1939, yes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Preliminary Checks
I have reviewed the documentation: https://clerk.com/docs
I have searched for existing issues: https://github.com/clerkinc/javascript/issues
I have not already reached out to Clerk support via email or Discord (if you have, no need to open an issue here)
This issue is not a question, general help request, or anything other than a bug report directly related to Clerk. Please ask questions in our Discord community: https://clerk.com/discord.
Reproduction / Replay Link
.
Publishable key
.
Description
Steps to reproduce:
Expected behavior:
The method should require its arguments are
ClerkMiddlewareOptionslike here:https://github.com/clerkinc/javascript/blob/main/packages/sdk-node/src/clerkExpressWithAuth.ts#L13C20-L13C42
Actual behavior:
It doesn't, the wrapper method has type
...args: any:https://github.com/clerkinc/javascript/blob/main/packages/sdk-node/src/clerkClient.ts#L78
So, you don't get any type safety using this method.
Environment
This is in the main branch of this repo.The text was updated successfully, but these errors were encountered: