Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): Use tsup to bundle the package for both cjs and esm #1314

Conversation

anagstef
Copy link
Member

@anagstef anagstef commented Jun 7, 2023

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

Description

  • npm test runs as expected.
  • npm run build runs as expected.

@anagstef anagstef self-assigned this Jun 7, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2023

⚠️ No Changeset found

Latest commit: 089e5fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Great news! Jit hasn't found any security issues in your PR. Good Job! 🏆

@nikosdouvlis nikosdouvlis force-pushed the stefanos/js-463-align-clerkbackend-build-config-with-clerkclerk-react branch from 31cbaa9 to 2a6e923 Compare June 13, 2023 10:34
…kage.esm.json

The ESM spec states that file imports within modules need to include the file extension, eg `import {} from './utils.js`, otherwise the module won't be correctly resolved.

We will add the types back in when we make the necessary adjustments to our build tooling.
@nikosdouvlis
Copy link
Member

This is blocked as we're currently coordinating with the Vercel team in order to resolve all issues related to turbopack. I will post updates once I have more details.

In the meantime, I'll try to cherry pick anything that can be merged right away.

@nikosdouvlis
Copy link
Member

nikosdouvlis commented Jun 23, 2023

Closing in favor of #1393

@dimkl dimkl deleted the stefanos/js-463-align-clerkbackend-build-config-with-clerkclerk-react branch June 23, 2023 09:19
@dimkl dimkl restored the stefanos/js-463-align-clerkbackend-build-config-with-clerkclerk-react branch June 23, 2023 09:20
@dimkl dimkl deleted the stefanos/js-463-align-clerkbackend-build-config-with-clerkclerk-react branch March 29, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants