-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(backend): Use tsup to bundle the package for both cjs and esm #1314
chore(backend): Use tsup to bundle the package for both cjs and esm #1314
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Great news! Jit hasn't found any security issues in your PR. Good Job! 🏆
31cbaa9
to
2a6e923
Compare
…ways treated as CJS
…kage.esm.json The ESM spec states that file imports within modules need to include the file extension, eg `import {} from './utils.js`, otherwise the module won't be correctly resolved. We will add the types back in when we make the necessary adjustments to our build tooling.
This is blocked as we're currently coordinating with the Vercel team in order to resolve all issues related to In the meantime, I'll try to cherry pick anything that can be merged right away. |
Closing in favor of #1393 |
Type of change
Packages affected
@clerk/clerk-js
@clerk/clerk-react
@clerk/nextjs
@clerk/remix
@clerk/types
@clerk/themes
@clerk/localizations
@clerk/clerk-expo
@clerk/backend
@clerk/clerk-sdk-node
@clerk/shared
@clerk/fastify
@clerk/chrome-extension
gatsby-plugin-clerk
build/tooling/chore
Description
npm test
runs as expected.npm run build
runs as expected.