fix(nextjs): Avoid setting clerkUrl port when http(s) forwarded port and protocol is defined #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 15bd1a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
dimkl
force-pushed
the
js-483-nextjs-hostname
branch
from
0490217
to
11b9198
Compare
|
!snapshot |
|
Hey @dimkl - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.23.6-snapshot.11b9198# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.17-snapshot.11b9198# @clerk/clerk-js
npm i @clerk/clerk-js@4.50.2-snapshot.11b9198# eslint-config-custom
npm i eslint-config-custom@0.3.0# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.8-snapshot.11b9198# @clerk/fastify
npm i @clerk/fastify@0.5.5-snapshot.11b9198# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.3.17-snapshot.11b9198# @clerk/localizations
npm i @clerk/localizations@1.22.0-snapshot.11b9198# @clerk/nextjs
npm i @clerk/nextjs@4.21.11-snapshot.11b9198# @clerk/clerk-react
npm i @clerk/clerk-react@4.20.6-snapshot.11b9198# @clerk/remix
npm i @clerk/remix@2.6.14-snapshot.11b9198# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.10.13-snapshot.11b9198# @clerk/shared
npm i @clerk/shared@0.19.1# @clerk/themes
npm i @clerk/themes@1.7.5# @clerk/types
npm i @clerk/types@3.46.1-snapshot.11b9198 |
dimkl
force-pushed
the
js-483-nextjs-hostname
branch
from
11b9198
to
3f7b6c5
Compare
|
!snapshot |
|
Hey @dimkl - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.23.6-snapshot.3f7b6c5# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.17-snapshot.3f7b6c5# @clerk/clerk-js
npm i @clerk/clerk-js@4.50.2-snapshot.3f7b6c5# eslint-config-custom
npm i eslint-config-custom@0.3.0# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.8-snapshot.3f7b6c5# @clerk/fastify
npm i @clerk/fastify@0.5.5-snapshot.3f7b6c5# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.3.17-snapshot.3f7b6c5# @clerk/localizations
npm i @clerk/localizations@1.22.0-snapshot.3f7b6c5# @clerk/nextjs
npm i @clerk/nextjs@4.21.11-snapshot.3f7b6c5# @clerk/clerk-react
npm i @clerk/clerk-react@4.20.6-snapshot.3f7b6c5# @clerk/remix
npm i @clerk/remix@2.6.14-snapshot.3f7b6c5# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.10.13-snapshot.3f7b6c5# @clerk/shared
npm i @clerk/shared@0.19.1# @clerk/themes
npm i @clerk/themes@1.7.5# @clerk/types
npm i @clerk/types@3.46.1-snapshot.3f7b6c5 |
dimkl
changed the title
dimkl
changed the title
desiprisg
approved these changes
Jun 26, 2023
dimkl
force-pushed
the
js-483-nextjs-hostname
branch
from
3f7b6c5
to
a17c43b
Compare
nikosdouvlis
approved these changes
Jun 27, 2023
dimkl
force-pushed
the
js-483-nextjs-hostname
branch
from
a17c43b
to
15bd1a5
Compare
nikosdouvlis
approved these changes
Jun 27, 2023
Merged
20 tasks
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Issue: #1413
PR introducing issue: #1394