-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): Add methods for uploading images to User and Organization #1456
Conversation
🦋 Changeset detectedLatest commit: 94de086 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Great news! Jit hasn't found any security issues in your PR. Good Job! 🏆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! Left a few comments, feel free to ignore them.
@panteliselef It would be a nice-to-have thing, and also to be consistent between FAPI and BAPI. Although, I don't think we actually need it. The Base64 support was implemented mainly to support Expo users. You can create a Blob/FIle from a Base64 string easily. |
Changes required for formData: - Content-type should be undefined - formData should be passed as body (not json stringified or deep merged with something)
This commit adds: - `updateOrganizationLogo` method in OrganizationApi class - `updateUserProfileImage` method in UserApi class
… `deleteOrganizationLogo`
73a6e68
to
462a522
Compare
This change adds support to node environments that do not provide built-in support to FormData class
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Type of change
Packages affected
@clerk/clerk-js
@clerk/clerk-react
@clerk/nextjs
@clerk/remix
@clerk/types
@clerk/themes
@clerk/localizations
@clerk/clerk-expo
@clerk/backend
@clerk/clerk-sdk-node
@clerk/shared
@clerk/fastify
@clerk/chrome-extension
gatsby-plugin-clerk
build/tooling/chore
Description
npm test
runs as expected.npm run build
runs as expected.This PR adds:
updateOrganizationLogo
method inOrganizationApi
classupdateUserProfileImage
method inUserApi
class