Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): Add methods for uploading images to User and Organization #1456

Merged
merged 4 commits into from
Jul 7, 2023

Conversation

anagstef
Copy link
Member

@anagstef anagstef commented Jul 5, 2023

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

Description

  • npm test runs as expected.
  • npm run build runs as expected.

This PR adds:

  • updateOrganizationLogo method in OrganizationApi class
  • updateUserProfileImage method in UserApi class

@anagstef anagstef requested review from gkats and dimkl July 5, 2023 16:35
@anagstef anagstef self-assigned this Jul 5, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2023

🦋 Changeset detected

Latest commit: 94de086

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@clerk/backend Minor
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Great news! Jit hasn't found any security issues in your PR. Good Job! 🏆

.changeset/spotty-months-worry.md Show resolved Hide resolved
Copy link
Member

@gkats gkats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Left a few comments, feel free to ignore them.

packages/backend/src/api/endpoints/OrganizationApi.ts Outdated Show resolved Hide resolved
packages/backend/src/api/endpoints/OrganizationApi.ts Outdated Show resolved Hide resolved
packages/backend/src/api/endpoints/UserApi.ts Show resolved Hide resolved
packages/backend/src/api/endpoints/UserApi.ts Outdated Show resolved Hide resolved
packages/backend/src/api/request.ts Show resolved Hide resolved
@panteliselef
Copy link
Member

@gkats @anagstef I believe we did some work in order to support images to be uploaded as DataURLs. This was done on FAPI. Is this something we could support here as well ?

@anagstef
Copy link
Member Author

anagstef commented Jul 7, 2023

@gkats @anagstef I believe we did some work in order to support images to be uploaded as DataURLs. This was done on FAPI. Is this something we could support here as well ?

@panteliselef It would be a nice-to-have thing, and also to be consistent between FAPI and BAPI. Although, I don't think we actually need it. The Base64 support was implemented mainly to support Expo users. You can create a Blob/FIle from a Base64 string easily.

dimkl and others added 3 commits July 7, 2023 13:58
Changes required for formData:
- Content-type should be undefined
- formData should be passed as body (not json stringified or deep merged with something)
This commit adds:

- `updateOrganizationLogo` method in OrganizationApi class
- `updateUserProfileImage` method in UserApi class
@anagstef anagstef force-pushed the js-433-user-set-profile-image-openapi branch from 73a6e68 to 462a522 Compare July 7, 2023 10:58
This change adds support to node environments that do not provide built-in support to FormData class
@anagstef anagstef merged commit 643ee54 into main Jul 7, 2023
8 checks passed
@anagstef anagstef deleted the js-433-user-set-profile-image-openapi branch July 7, 2023 11:38
@clerk-cookie clerk-cookie mentioned this pull request Jul 7, 2023
@clerk-cookie
Copy link
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants