Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): Pin versions of all internal dependencies #1798

Merged
merged 8 commits into from
Oct 2, 2023

Conversation

BRKalow
Copy link
Member

@BRKalow BRKalow commented Sep 28, 2023

Description

Pins the internal dependency versions. This ensures that users installing our main framework SDKs will get consistent versions across all @clerk/ packages.

In practice, this shouldn't change much for how we publish or what packages get installed, we already have Changesets configured to always bump internal dependencies, but it is more exact and should minimize and potential package version drift.

fixes JS-695

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@BRKalow BRKalow requested review from dimkl and a team as code owners September 28, 2023 21:52
@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023

🦋 Changeset detected

Latest commit: 3b1b23f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@clerk/backend Patch
@clerk/chrome-extension Patch
@clerk/clerk-js Patch
@clerk/clerk-expo Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/shared Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@nikosdouvlis nikosdouvlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next Changesets bumps the versions, will it bump to a pinned version or will it add the caret in front ?

@BRKalow
Copy link
Member Author

BRKalow commented Sep 29, 2023

@panteliselef I believe it will keep the versions pinned. I will double-check though!

@BRKalow BRKalow enabled auto-merge October 2, 2023 04:54
@nikosdouvlis
Copy link
Member

@BRKalow @panteliselef
Changesets will bump the version respecting the absence of the caret with no issues. Merging this one :)

@BRKalow BRKalow added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit 0636ff7 Oct 2, 2023
6 checks passed
@BRKalow BRKalow deleted the brk.chore/pin-clerk-versions branch October 2, 2023 14:38
@clerk-cookie clerk-cookie mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants