Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js): Allow customization of OrganizationProfile through OrganizationSwitcher #1801

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Sep 29, 2023

Description

This PR

  • introduces organizatinonProfileProps as prop of <OrganizationSwitcher />. This allows for the customization of OrganizationProfile when it is opened through the switcher.
  • introduces appearance in userProfileProps of <UserButton/>.
  • deprecates the usage of appearance.userProfile of <UserButton/>.

After these changes a developer can customize the Profiles like this:

      <OrganizationSwitcher
        organizationProfileProps={{
          appearance: {
            elements: {
              formButtonPrimary: {
                background: 'black',
              },
            },
          },
        }}
      />
      <UserButton
        userProfileProps={{
          appearance: {
            elements: {
              formButtonPrimary: {
                background: 'orange',
              },
            },
          },
        }}
      />

Deprecated

      <UserButton
        appearance={{
          userProfile: {
            elements: {
              formButtonPrimary: {
                background: 'black',
              },
            },
          },
        }}
      />

Fixes #1534

Checklist

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@panteliselef panteliselef requested a review from a team as a code owner September 29, 2023 13:01
@panteliselef panteliselef self-assigned this Sep 29, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2023

🦋 Changeset detected

Latest commit: 591bcbb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +56 to +58
appearance: opts.appearance?.userProfile,
// Prioritize the appearance of `userProfileProps`
...opts.userProfileProps,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@panteliselef panteliselef changed the title [WIP] feat(clerk-js): Allow customization of OrganizationProfile through OrganizationSwitcher feat(clerk-js): Allow customization of OrganizationProfile through OrganizationSwitcher Sep 29, 2023
Copy link
Member

@nikosdouvlis nikosdouvlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panteliselef good job, this is much better than before.

…ganizationSwitcher

Expose organizationProfileProps from switcher and deprecate UserButton appearance
@panteliselef panteliselef added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit b59b6b7 Oct 2, 2023
6 checks passed
@panteliselef panteliselef deleted the ORG-87 branch October 2, 2023 12:19
@clerk-cookie clerk-cookie mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrganizationSwitcher missing organizationProfile appearance attribute
4 participants