feat(clerk-js,types): Add appearance keys for pagination and table head #1803
Conversation
🦋 Changeset detectedLatest commit: 8dc7d81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
octoper
force-pushed
the
vaggelis/js-754-add-external-class-to-organizationprofile-members-table
branch
2 times, most recently
from
37f04af
to
68094ab
Compare
octoper
force-pushed
the
vaggelis/js-754-add-external-class-to-organizationprofile-members-table
branch
from
9600b54
to
5a41fef
Compare
| localizationKey={localizationKeys('paginationRowText__displaying')} | ||
| />{' '} | ||
| <Text | ||
| as='span' | ||
| colorScheme='inherit' |
There was a problem hiding this comment.
@octoper I see we made some minor UI changes here, could you please add a screenshot in the PR description if needed? Even if the changes are minor, this always helps and we can use it for future reference as well.
There was a problem hiding this comment.
Yes, let's add a before and after showcasing why we need to use inherit here.
There was a problem hiding this comment.
The main reason I used colorScheme='inherit' here is just to have the colour to the parent element so I can use the element descriptor only theme.
There was a problem hiding this comment.
@octoper I'm very skeptic about the result of the before/active. This is something i recently touched as well, but endup not making the change.
I don't think using the primary colour here makes sense, and the result is not that elegant.
There was a problem hiding this comment.
@panteliselef Yeah it's not that elegant but I thought that this should match the other parts of our components that have text, because if this is not changed every other part will have the primary colour and this will be black.
octoper
force-pushed
the
vaggelis/js-754-add-external-class-to-organizationprofile-members-table
branch
2 times, most recently
from
fe6598b
to
e7f1993
Compare
octoper
force-pushed
the
vaggelis/js-754-add-external-class-to-organizationprofile-members-table
branch
from
e7f1993
to
448a860
Compare
octoper
force-pushed
the
vaggelis/js-754-add-external-class-to-organizationprofile-members-table
branch
from
2b841ea
to
19c6aa3
Compare
…d too complex union type errors
octoper
force-pushed
the
vaggelis/js-754-add-external-class-to-organizationprofile-members-table
branch
from
820e858
to
5b51cc8
Compare
octoper
deleted the
vaggelis/js-754-add-external-class-to-organizationprofile-members-table
branch
Description
Add missing appearance keys for Pagination text and buttons and Table head.
Before
After
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore