-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(clerk-js,backend,shared):Apply deprecation warnings @clerk/types
#1823
Conversation
🦋 Changeset detectedLatest commit: 10fb826 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bffe9d9
to
63f77bd
Compare
1e91a8d
to
339eeba
Compare
9acaa62
to
319d166
Compare
67930d2
to
d8a7164
Compare
import type { PublicUserDataJSON } from '@clerk/types'; | ||
|
||
export class OrganizationPublicUserData implements PublicUserData { | ||
export class PublicUserData implements IPublicUserData { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Why are we renaming this class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the publicUserData
property is the same for all Resources (eg OrganizationMembership
, Session
), so there is no need to create a separate class for each resource.
d8a7164
to
fbad687
Compare
…rontendApi deprecations
fbad687
to
10fb826
Compare
Hi I am now getting DEPRECATION WARNING: "frontendApi" is deprecated and will be removed in the next major release. |
Hello @ZeldOcarina |
Hi @dimkl it only says this:
I am just using these as envs:
|
@ZeldOcarina let me take a better look at it, and I will get back to you :) |
I am using :
That env was in an old guide, if not needed anymore I can delete it I am not manually using it anywhere! |
@ZeldOcarina you can drop this env. |
Hey @dimkl, I'm still getting the warning:
I'm using
and I have the following env defined:
|
@yns01 thanks for reporting this, i will take a look and come back. |
@yns01 Should be fixed in |
Description
Review it per commit
Deprecations:
orgs
jwt claimsapiKey
frontendApi
redirect_url
password
generateSignature
afterSwitchOrganizationUrl
profileImageUrl
Other changes:
frontendApi
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change
Packages affected
@clerk/clerk-js
@clerk/clerk-react
@clerk/nextjs
@clerk/remix
@clerk/types
@clerk/themes
@clerk/localizations
@clerk/clerk-expo
@clerk/backend
@clerk/clerk-sdk-node
@clerk/shared
@clerk/fastify
@clerk/chrome-extension
gatsby-plugin-clerk
build/tooling/chore