Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-sdk-node): Fix types of ClerkExpressWithAuth/ClerkExpressRequireAuth args #1939

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

dimkl
Copy link
Contributor

@dimkl dimkl commented Oct 25, 2023

Description

Resolves #1938

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@dimkl dimkl self-assigned this Oct 25, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

🦋 Changeset detected

Latest commit: 1238c22

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-sdk-node Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimkl dimkl requested a review from a team October 25, 2023 18:41
@nikosdouvlis nikosdouvlis reopened this Oct 25, 2023
@dimkl dimkl force-pushed the fix-clerk-express-require-auth branch from 104818f to 1238c22 Compare October 25, 2023 19:11
.github/workflows/nightly-checks.yml Outdated Show resolved Hide resolved
@dimkl dimkl requested a review from anagstef October 26, 2023 01:07
@dimkl dimkl closed this Oct 26, 2023
@dimkl dimkl reopened this Oct 26, 2023
@dimkl dimkl force-pushed the fix-clerk-express-require-auth branch from 42ea608 to 1238c22 Compare October 26, 2023 01:12
@dimkl dimkl added this pull request to the merge queue Oct 26, 2023
Merged via the queue into main-v4 with commit 5d379bc Oct 26, 2023
24 checks passed
@dimkl dimkl deleted the fix-clerk-express-require-auth branch October 26, 2023 18:17
LekoArts pushed a commit that referenced this pull request Oct 26, 2023
dimkl added a commit that referenced this pull request Oct 30, 2023
dimkl added a commit that referenced this pull request Oct 30, 2023
octoper pushed a commit that referenced this pull request Oct 31, 2023
dimkl added a commit that referenced this pull request Oct 31, 2023
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2023
* fix(clerk-sdk-node): Fix types of ClerkExpressWithAuth/ClerkExpressRequireAuth args (#1939)

#1938

* fix(backend): Support NextJS 14 (#1948)

* fix(backend): Fix for next 14 fetch bind issue

* fix(nextjs): Use named imports for fetch runtime polyfill

Next14 seems to have changed the way it handles default exports when using the webpack bundler for some of their build variants when using `npm run dev`. This commit ensures that we no longer use the default export in an effort to improve compat between the different nextjs versions.

More information can be found here: https://esbuild.github.io/content-types/#default-interop
and here: #612

* Create late-dolphins-peel.md

---------

Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>

---------

Co-authored-by: George Desipris <73396808+desiprisg@users.noreply.github.com>
Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants