Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clerk-js,types): Remove system delete permission for domains and memberships #2256

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Dec 4, 2023

Description

The delete permission has been merged with manage. We are still keeping org:sys_profile:delete as a separate permission.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

…d memberships

The `delete` permission has been merged with `manage`
@panteliselef panteliselef self-assigned this Dec 4, 2023
Copy link

changeset-bot bot commented Dec 4, 2023

🦋 Changeset detected

Latest commit: 9caebd4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 4, 2023

⚠️ Changes detected under the ClerkJS ui directory!

Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**

Also, you may need to update the following files:

  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts

@panteliselef panteliselef marked this pull request as ready for review December 4, 2023 16:34
@panteliselef panteliselef requested a review from a team December 4, 2023 16:35
@panteliselef panteliselef added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit 6a33709 Dec 5, 2023
8 of 9 checks passed
@panteliselef panteliselef deleted the elef/core-1139-remove-delete-permissions branch December 5, 2023 20:56
tmilewski pushed a commit that referenced this pull request Dec 6, 2023
…d memberships (#2256)

The `delete` permission has been merged with `manage`
panteliselef added a commit that referenced this pull request Dec 6, 2023
nikosdouvlis pushed a commit that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants