Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nextjs): Fix quickstarts link in error msg #2354

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

dimkl
Copy link
Contributor

@dimkl dimkl commented Dec 14, 2023

Description

Backports #2355

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@dimkl dimkl self-assigned this Dec 14, 2023
@dimkl dimkl requested a review from a team as a code owner December 14, 2023 18:35
@dimkl dimkl requested review from octoper and removed request for a team December 14, 2023 18:35
Copy link

changeset-bot bot commented Dec 14, 2023

🦋 Changeset detected

Latest commit: 8049b3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -36,7 +36,7 @@ export const authAuthHeaderMissing = (helperName = 'auth') =>
- Your Middleware matcher is configured to match this route or page.
- If you are using the src directory, make sure the Middleware file is inside of it.

For more details, see https://clerk.com/docs/quickstarts/get-started-with-nextjs.
For more details, see https://clerk.com/docs/quickstarts/nextjs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the . at the end of line because it was considered part of the link and the .../nextjs. url does not exist.

@dimkl dimkl enabled auto-merge December 14, 2023 20:57
@dimkl dimkl added this pull request to the merge queue Dec 14, 2023
Merged via the queue into release/v4 with commit e47c115 Dec 14, 2023
7 checks passed
@dimkl dimkl deleted the fix-nextjs-quickstart-link branch December 14, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants