fix(clerk-js,localizations,types): Add formFieldHintText__slug key
#1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables you to translate the tooltip hint while creating an organization
🦋 Changeset detectedLatest commit: c6ff3ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
approved these changes
Oct 2, 2023
panteliselef
reviewed
Oct 2, 2023
| @@ -352,7 +352,7 @@ export const FormControl = forwardRef<HTMLInputElement, PropsWithChildren<FormCo | |||
| const Icon = icon ? ( | |||
| <Flex | |||
| as={'span'} | |||
| title='A slug is a human-readable ID that must be unique. It’s often used in URLs.' | |||
| title={t(localizationKeys('formFieldHintText__slug'))} | |||
There was a problem hiding this comment.
how about this instead ?
Suggested change
| title={t(localizationKeys('formFieldHintText__slug'))} | |
| title={t(localizationKeys('formFieldIconText__organizationSlug'))} |
There was a problem hiding this comment.
If we want to reuse this in other places, hintText__slug is more generic and appropriate than tying this specific to organizations. The text isn't mentioning Organizations
LekoArts
deleted the
lekoarts/js-776-be-able-to-translate-what-is-a-slug-tooltip
branch
Merged
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables you to translate the tooltip hint while creating an organization
Fixes #1795
Fixes ORG-239
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore