Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Make target for building .sass files in Docker and use it in CI to verify the generated CSS files #8

Open
xmudrii opened this issue Jul 2, 2018 · 1 comment
Open

Create a Make target for building .sass files in Docker and use it in CI to verify the generated CSS files #8

xmudrii opened this issue Jul 2, 2018 · 1 comment
Labels
area/hugo Issues relating to Hugo

Comments

@xmudrii
Copy link
Contributor

xmudrii commented Jul 2, 2018 •
edited
Loading

From @munnerz's comment on #7:

馃憤 we can look at creating a 'build' docker image later, as well as setting up a verify stage as part of CI to ensure the generated CSS is up-to-date.

Currently, in order to generate CSS files from .sass files, you need node-sass installed on your local machine, which is available on npm, therefore requires you to have npm installed as well. It would be nice to provide a Make target to use Docker to build CSS files from SASS files, as in that case you don't need to install npm and node-sass on your local machine.
@xmudrii
Copy link
Contributor Author

xmudrii commented Jul 2, 2018

/area hugo

@k8s-ci-robot k8s-ci-robot added the area/hugo Issues relating to Hugo label Jul 2, 2018
@xmudrii xmudrii mentioned this issue Jul 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/hugo Issues relating to Hugo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xmudrii @k8s-ci-robot