Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Manhattan router not avoiding obstacles correctly when step < 7 #2763

Open
alexandernst opened this issue Sep 25, 2024 · 0 comments
Open
Labels

Comments

@alexandernst
Copy link
Contributor

alexandernst commented Sep 25, 2024

Current versus expected behaviour

Note

This is a follow up from #2738 (reply in thread)

Hi @kumilingus !

I've been playing around with the code you gave me in the manhattan-router discussion the other day and I saw something that I thought is worth mentioning. Certain situations lead to the manhattan router creating extra vertices:

image

I'm aware that this might be (¿?) caused by the step option and because of the way collisions are detected (¿?), which is fine, but if I set the step value to 1 (actually any value below 7), manhattan just stops avoiding any obstacles at all.

image

I tried debugging the code and re-reading all the docs, and I believe there is a correlation between step and gridSize, but setting the later to the same value doesn't fix the problem.

Why isn't manhattan avoiding obstacles when step < 7 ?

Steps to reproduce

  1. Go to https://codesandbox.io/p/sandbox/runtime-dream-8ffcy9
  2. Change step to any value below 7
  3. Move the cells and check if the link is avoiding the cells

Version

4.0.4

What browsers are you seeing the problem on?

Chrome, Safari

What operating system are you seeing the problem on?

Mac

@alexandernst alexandernst changed the title [Bug]: Manhattan router not avoiding obstacles correctly when step < 5 [Bug]: Manhattan router not avoiding obstacles correctly when step < 7 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant