Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clinic Flare exits silently on Apple Silicon and node < 16 #321

Closed
giovanni-bertoncelli opened this issue Jan 5, 2022 · 3 comments
Closed
Labels
wontfix This will not be worked on

Comments

@giovanni-bertoncelli
Copy link

giovanni-bertoncelli commented Jan 5, 2022

Expected Behavior

When I run the clinic flare inspector I expect that the node script executes completely before exiting and gathering statistics.

Current Behavior

It seems that in my environment even with a super-simple script with a single console.log the flare inspector considers the node script exiting immediately and does not run the script at all, gathering at the end empty statistics. No errors are thrown.

Steps to Reproduce (for bugs)

  1. Get a MacBook with Apple Silicon/M1
  2. Install with nvm node version 12 or less than 16
  3. Create a simple script
  4. Run clinic flare with the script
  5. The script is not executed and flare exits

Sample upload

// test.js
console.log("you'll never see this log!")
clinic flare -- node test.js

Environment

  • Clinic.js version:
    Flare v11.0.0 (0x v5.0.0)
  • Node.js version:
    v12.22.7 (on Rosetta)
  • Operating system and version:
    macOS Monterey 12.1 with M1 chip
@mcollina
Copy link
Contributor

mcollina commented Jan 5, 2022

I think Node.js started supporting M1 Macs officially from Node v16. There might be plenty of things going wrong.

@giovanni-bertoncelli
Copy link
Author

Yes, natively it works only with Node v16 and above. But by emulating with Rosetta I think every nodejs version should be compatible: https://doesitarm.com/app/nodejs/, ThatGuySam/doesitarm#299 (comment)

@mcollina mcollina added the wontfix This will not be worked on label Jan 5, 2022
@mcollina
Copy link
Contributor

mcollina commented Jan 5, 2022

The command is:

clinic flame -- node test.js

Generating flamegraphs is quite a low level task. I would be very surprised if it worked over Rosetta.

I would be happy to receive a PR to make this happen, however I don't think it's something we have the bandwidth to support given that Node v16 is now LTS.

If you have a commercial need for this we (NearForm) are happy to provide long-term support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants