Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec failures in Rails 4.2 #30

Open
arthurchui opened this issue May 25, 2020 · 0 comments
Open

Spec failures in Rails 4.2 #30

arthurchui opened this issue May 25, 2020 · 0 comments

Comments

@arthurchui
Copy link
Contributor

arthurchui commented May 25, 2020

There are 3 broken specs in Rails 4.2. Fix them if they are not too difficult; otherwise we should officially discontinue to support Rails 4.

# Update jit_preloader.gemspec
spec.add_dependency "activerecord", ">= 4.2"
spec.add_development_dependency "sqlite3", "< 1.4"
> bundle exec rspec spec

  1) JitPreloader::Preloader for single table inheritance when preloading an aggregate of a child model through its base model can handle queries
     Failure/Error: expect(contact_books.first.employees_count).to eq 4

       expected: 4
            got: 0

       (compared using ==)
     # ./spec/lib/jit_preloader/preloader_spec.rb:75:in `block (4 levels) in <top (required)>'

  2) JitPreloader::Preloader for single table inheritance when preloading an aggregate of a nested child model through another child model can handle queries
     Failure/Error: expect(contact_books.first.company_employees_count).to eq 2

       expected: 2
            got: 0

       (compared using ==)
     # ./spec/lib/jit_preloader/preloader_spec.rb:91:in `block (4 levels) in <top (required)>'

  3) JitPreloader::Preloader for single table inheritance when preloading an aggregate of a nested child model through a many-to-many relationship with another child model can handle queries
     Failure/Error: expect(contact_books.first.children_count).to eq 4

       expected: 4
            got: 0

       (compared using ==)
     # ./spec/lib/jit_preloader/preloader_spec.rb:105:in `block (4 levels) in <top (required)>'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant