Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FiltersEngine updates stress test #176

Merged
merged 9 commits into from
Jun 17, 2019
Merged

Conversation

remusao
Copy link
Collaborator

@remusao remusao commented Jun 14, 2019

  • In debug mode, make FiltersEngine creation and updates deterministic
  • Fix bug in ID computation for :style(...) cosmetic filters
  • Detect invalid cases of domain= options in NetworkFilter
  • Make generateDiff more robust and cover corner case with ID collision
  • Add stress-test for FiltersEngine updates. This allows us to validate all past updates of all supported lists

@remusao remusao force-pushed the engine-corruption branch 2 times, most recently from 1881e6e to e9a6882 Compare June 14, 2019 15:46
@remusao remusao changed the title Engine corruption FiltersEngine updates stress test Jun 17, 2019
@remusao remusao force-pushed the engine-corruption branch from 6516271 to b128aca Compare June 17, 2019 10:08
@remusao remusao merged commit dd51a39 into ghostery:master Jun 17, 2019
@remusao remusao mentioned this pull request Jun 17, 2019
remusao added a commit that referenced this pull request Jun 17, 2019
* In `debug` mode, make FiltersEngine creation and updates deterministic [#176](#176)
* Fix bug in ID computation for `:style(...)` cosmetic filters [#176](#176)
* Detect invalid cases of `domain=` options in NetworkFilter [#176](#176)
* Make `generateDiff` more robust and cover corner case with ID collision [#176](#176)
* Add stress-test for FiltersEngine updates. This allows us to validate all past updates of all supported lists [#176](#176)
* Provide high level puppeteer blocker abstraction [#177](#177)
  * [BREAKING] rename `WebExtensionEngine` into `WebExtensionBlocker`
  * [BREAKING] change format of `redirect` field in blocking response, it now
    exposes more information about the redirected resource: `contentType`,
    `body` and `dataUrl` (which was the only information originally returned
    by `FiltersEngine.match(...)`).
  * Rename `example` into `examples` and move test webextension into `examples/webextension`
* Add missing dependencies on @types/puppeteer needed by users of the library [#174](#174)
@remusao remusao deleted the engine-corruption branch September 5, 2019 11:40
@remusao remusao added the PR: Polish 💅 Increment patch version when merged label Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 Increment patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant