-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PuppeteerBlocker abstraction #177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remusao
changed the title
High level abstractions
Implement PuppeteerBlocker abstraction
Jun 15, 2019
* Remove use of for...of * Make conditions more specific in PuppeteerBlocker.onRequest
Merged
remusao
added a commit
that referenced
this pull request
Jun 17, 2019
* In `debug` mode, make FiltersEngine creation and updates deterministic [#176](#176) * Fix bug in ID computation for `:style(...)` cosmetic filters [#176](#176) * Detect invalid cases of `domain=` options in NetworkFilter [#176](#176) * Make `generateDiff` more robust and cover corner case with ID collision [#176](#176) * Add stress-test for FiltersEngine updates. This allows us to validate all past updates of all supported lists [#176](#176) * Provide high level puppeteer blocker abstraction [#177](#177) * [BREAKING] rename `WebExtensionEngine` into `WebExtensionBlocker` * [BREAKING] change format of `redirect` field in blocking response, it now exposes more information about the redirected resource: `contentType`, `body` and `dataUrl` (which was the only information originally returned by `FiltersEngine.match(...)`). * Rename `example` into `examples` and move test webextension into `examples/webextension` * Add missing dependencies on @types/puppeteer needed by users of the library [#174](#174)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable full adblocking in puppeteer with only few lines of code: