Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent preload script from overwriting existing ones #302

Merged
merged 1 commit into from
Aug 28, 2019
Merged

fix: prevent preload script from overwriting existing ones #302

merged 1 commit into from
Aug 28, 2019

Conversation

sentialx
Copy link
Contributor

Hi, I noticed in my project that adblocker-electron overwrites existing preloads, so I pushed a little fix.

remusao
remusao approved these changes Aug 28, 2019
View reviewed changes
Copy link
Collaborator

@remusao remusao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks a lot for contributing a fix.

@remusao remusao merged commit 9bf8074 into ghostery:master Aug 28, 2019
@remusao remusao mentioned this pull request Aug 28, 2019
Merged
@remusao
Copy link
Collaborator

remusao commented Aug 28, 2019 •
edited
Loading

@sentialx Fix released in v1.0.1. Thanks again for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remusao remusao remusao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentialx @remusao