Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deps.edn #41

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Add deps.edn #41

merged 1 commit into from
Jan 9, 2020

Conversation

kailes
Copy link
Contributor

@kailes kailes commented Jan 2, 2020

Currently, clojure users can only pull in released versions by specifying iapetos as a :mvn/version dependency. This patch add file deps.edn, so clojure users could specify the dependency as a :git/url and :sha to pull down and test unreleased versions.

@kailes
Copy link
Contributor Author

kailes commented Jan 9, 2020

iapetos-0.1.9 will get an IOException when using push!. We're using Clojure CLI tools which can only pull this version on Clojars.

Appreciate if this patch can be merged, or release a new version with io.prometheus 0.8.0, which can fix the bug.

Thanks, friendly ping @MalloZup

Copy link
Member

@MalloZup MalloZup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@MalloZup MalloZup merged commit 5c2185f into clj-commons:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants