-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Processing reader conditionals broken #164
Comments
Thanks for reporting, I'll put this on the roadmap for 9.2 |
This one is driving me nuts, I added a cljc file to the test projects and I can't seem to reproduce the error locally with lein test. I can reproduce it by cloning semantic-csv and running lein marge on it, but that's not really something I can add to my automated tests |
Woah; crazy. Do you have a branch for this? I could try to take a look and see if I can't get your test to fail. Do you have a hunch on the issue? Could clj/cljs version discrepancy be at fault, or do you think there's some edge case not being caught? Thanks for your time looking into this. I've been wanting to mint a new release of semantic-csv, but have been stalling to see if we can't get the docs up in order. |
I think it's because my automated tests are broken so the code in the test projects folder is being missed somehow. Once I shave that yack I should be able to get back to the issue at hand. The quick fix might be to just move my parser code into a cljc file so if the reader thinks it's running the code in the parser context it will be fine. |
Any updates on or workarounds for this? |
@gdeer81 Has there been any progress on this? I've been waiting to release semantic-csv out of alpha for about a year now because I don't want to do so without having updated the docs. I really like marginalia and don't want to switch doc systems if I don't have to, but my users are getting a bit restless at not having a recent stable & documented release out. |
I've been seeing this same error. When I built and installed darwindarak's pull request #175 it fixed the problem. +1 to that PR. |
Awesome! Thanks for the update @darren-fhf. @gdeer81 Can we please get this merged in and released? I'd been holding off on minting a new release of semantic-csv till the docs are sorted out, and would love to get it out! Thanks in advance! |
Fixed in #183; will be released in 0.9.2 (give me a ping if you're antsy for the release to come out). |
I see from #103 that
cljc
should now be fixed now. However, I'm still not able to generate documentation for https://github.com/metasoarous/semantic-csv (try executing the./build_docs.sh
script), and get the following error:Any updates on this?
The text was updated successfully, but these errors were encountered: