-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering metrics with Clojure functions #105
Comments
You can either
I'm not aware of a way to filter out metrics in reporters other than duplicating the entire metric registry and removing some keys right before sending the data. |
By the way, I am open to ideas about how to address this but I'm afraid this specific library is largely at the mercy of a feature provided in Dropwizard Metrics. Unless we want to subclass every single reporter, at least. |
Actually, there is MetricFilter which can be passed in but there is no way to define one as a Clojure function. |
When you say "passed in", where is it passed? |
To functions that instantiate metric reporters. |
Awesome, I'll take a look at this. If it works well, I'll put together a PR to make it more Clojure native. |
We're using Hosted Graphite (great service btw), and we are charged by our metric count. We have ring metrics, JVM metrics, and custom metrics and are going over our cap. I'd like to filter some of the ring metrics as we only need a few from here, but it's not clear if/how to do that? I read the docs on removing metrics, but it seemed like they would just be recreated later.
What's the recommended way of filtering the metrics that get sent to a (graphite) reporter?
The text was updated successfully, but these errors were encountered: