From 64d9beabe234c4b1dfd011a4cc152a827a40b0c9 Mon Sep 17 00:00:00 2001 From: Piotr Sarnacki Date: Fri, 6 Oct 2023 17:24:30 +0200 Subject: [PATCH] base and head refs are not needed anymore --- .github/workflows/benchmarks.yml | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index cfb452182c3..942aef44a80 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -38,14 +38,6 @@ jobs: with: fetch-depth: 10 - - name: Set up for PR context - if: github.event.inputs.pr_number - run: | - echo "PR_NUMBER=${{ github.event.inputs.pr_number }}" >> $GITHUB_ENV - PR_DATA=$(gh api repos/${{ github.repository }}/pulls/${{ github.event.inputs.pr_number }} --jq '{ baseRefName: .base.ref, headRefName: .head.ref }') - echo "PR_BASE_REF=$(echo $PR_DATA | jq -r '.baseRefName')" >> $GITHUB_ENV - echo "PR_HEAD_REF=$(echo $PR_DATA | jq -r '.headRefName')" >> $GITHUB_ENV - - name: Install stable toolchain uses: actions-rs/toolchain@v1 with: @@ -79,7 +71,7 @@ jobs: # TODO: can we optionally download if it only might fail? #- name: PR; download bench results for compare - # if: ${{ env.PR_BASE_REF }} + # if: github.event.inputs.pr_number # uses: actions/github-script@v6 # with: # github-token: ${{secrets.GITHUB_TOKEN}} @@ -93,7 +85,7 @@ jobs: # } - name: PR; run bench - if: ${{ env.PR_BASE_REF }} + if: github.event.inputs.pr_number working-directory: crates/bench/ run: | echo "Running benchmarks without sqlite" @@ -104,7 +96,7 @@ jobs: cp target/criterion/branch.json criterion-results/pr-$PR_NUMBER.json - name: PR; compare benchmarks - if: ${{ env.PR_BASE_REF }} + if: github.event.inputs.pr_number working-directory: crates/bench/ run: | if [ -e target/criterion/master.json ]; then