From c8279e1714999681e5a49bf9a835b65bac547b0c Mon Sep 17 00:00:00 2001
From: Ingvar Stepanyan <me@rreverser.com>
Date: Tue, 10 Sep 2024 18:06:39 +0100
Subject: [PATCH] C#: hide ReadGenFields from the public API (#1690)

---
 .../fixtures/server/snapshots/Module#PrivateTable.verified.cs | 2 +-
 .../fixtures/server/snapshots/Module#PublicTable.verified.cs  | 2 +-
 .../snapshots/Module#Timers.SendMessageTimer.verified.cs      | 4 +++-
 crates/bindings-csharp/Codegen/Module.cs                      | 2 +-
 4 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#PrivateTable.verified.cs b/crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#PrivateTable.verified.cs
index a25e8acba6..d3bfe38489 100644
--- a/crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#PrivateTable.verified.cs
+++ b/crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#PrivateTable.verified.cs
@@ -26,7 +26,7 @@ SpacetimeDB.BSATN.ITypeRegistrar registrar
             ));
     }
 
-    public void ReadGenFields(System.IO.BinaryReader reader) { }
+    void SpacetimeDB.Internal.ITable<PrivateTable>.ReadGenFields(System.IO.BinaryReader reader) { }
 
     static SpacetimeDB.Internal.TableDesc SpacetimeDB.Internal.ITable<PrivateTable>.MakeTableDesc(
         SpacetimeDB.BSATN.ITypeRegistrar registrar
diff --git a/crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#PublicTable.verified.cs b/crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#PublicTable.verified.cs
index d85fda78e6..98cd813791 100644
--- a/crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#PublicTable.verified.cs
+++ b/crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#PublicTable.verified.cs
@@ -188,7 +188,7 @@ SpacetimeDB.BSATN.ITypeRegistrar registrar
             ));
     }
 
-    public void ReadGenFields(System.IO.BinaryReader reader)
+    void SpacetimeDB.Internal.ITable<PublicTable>.ReadGenFields(System.IO.BinaryReader reader)
     {
         if (Id == default)
         {
diff --git a/crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#Timers.SendMessageTimer.verified.cs b/crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#Timers.SendMessageTimer.verified.cs
index f864317e21..a6ce27cbce 100644
--- a/crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#Timers.SendMessageTimer.verified.cs
+++ b/crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#Timers.SendMessageTimer.verified.cs
@@ -53,7 +53,9 @@ SpacetimeDB.BSATN.ITypeRegistrar registrar
         public ulong ScheduledId;
         public SpacetimeDB.ScheduleAt ScheduledAt;
 
-        public void ReadGenFields(System.IO.BinaryReader reader)
+        void SpacetimeDB.Internal.ITable<SendMessageTimer>.ReadGenFields(
+            System.IO.BinaryReader reader
+        )
         {
             if (ScheduledId == default)
             {
diff --git a/crates/bindings-csharp/Codegen/Module.cs b/crates/bindings-csharp/Codegen/Module.cs
index 4e67c81223..9c69d396c8 100644
--- a/crates/bindings-csharp/Codegen/Module.cs
+++ b/crates/bindings-csharp/Codegen/Module.cs
@@ -183,7 +183,7 @@ public override Scope.Extensions ToExtensions()
 
         extensions.Contents.Append(
             $$"""
-            public void ReadGenFields(System.IO.BinaryReader reader) {
+            void {{iTable}}.ReadGenFields(System.IO.BinaryReader reader) {
                 {{string.Join(
                     "\n",
                     autoIncFields.Select(name =>