Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow_dispatch for ci.yml #1295

Merged
merged 4 commits into from
May 24, 2024
Merged

Fix workflow_dispatch for ci.yml #1295

merged 4 commits into from
May 24, 2024

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented May 24, 2024

Description of Changes

Followup fixes to #1289.

Now that the original PR merged, it is possible to test the workflow_dispatch event on this PR without first merging it!

Expected complexity level and risk

2

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • CI runs normally on this PR
  • Manual run passes: Actions -> CI -> Run workflow -> Use version from bfops/fix-workflow-dispatch -> Enter PR number

@bfops bfops added the no runtime change This change does not affect the final binaries label May 24, 2024
@bfops bfops marked this pull request as ready for review May 24, 2024 16:25
@bfops bfops requested a review from kazimuth May 24, 2024 16:25
Copy link
Contributor

@kazimuth kazimuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Github Actions fun.

Have we done a manual run against this branch to make sure this works?

@bfops
Copy link
Collaborator Author

bfops commented May 24, 2024

Isn't Github Actions fun.

Have we done a manual run against this branch to make sure this works?

Yup! Added a link in the Testing section too.

@bfops bfops added this pull request to the merge queue May 24, 2024
@bfops bfops added the release-any To be landed in any release window label May 24, 2024
Merged via the queue into master with commit 0bf5d74 May 24, 2024
15 checks passed
@bfops bfops deleted the bfops/fix-workflow-dispatch branch September 5, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no runtime change This change does not affect the final binaries release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants