Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle loading old module versions from disk #1512

Open
cloutiertyler opened this issue Jul 15, 2024 · 4 comments
Open

Gracefully handle loading old module versions from disk #1512

cloutiertyler opened this issue Jul 15, 2024 · 4 comments
Assignees
@coolreader18

Comments

@cloutiertyler
Copy link
Contributor

The expected behavior is that if SpacetimeDB loads an out of date Wasm module, it should shut down that module, and any calls to that module should return an error which indicates that the module is not running and is out of date.
@cloutiertyler
Copy link
Contributor Author

I am not sure of the current behavior

@cloutiertyler
Copy link
Contributor Author

This is an ABI break if we have to add a version number or something to the module, although I'm fairly certain our existing version number would suffice. @coolreader18 Could you determine if this can be done with our existing ABI proposal?

@cloutiertyler
Copy link
Contributor Author

@coolreader18 has determined that this is not a breaking change to implement.

@cloutiertyler
Copy link
Contributor Author

See: https://discord.com/channels/1037340874172014652/1138987509834059867/1293674021501796535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coolreader18 coolreader18

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cloutiertyler @coolreader18