Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] Mark experimental API #1769

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

RReverser
Copy link
Member

Description of Changes

Spent a bit of time investigating #if, but found that there's a better (and easier) way nowadays.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

@RReverser RReverser added the api-break A PR that breaks some user-visible API label Sep 30, 2024
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you put a comment explaining why we chose this naming structure.

@RReverser
Copy link
Member Author

LGTM. Can you put a comment explaining why we chose this naming structure.

Done.

@RReverser RReverser added this pull request to the merge queue Sep 30, 2024
Merged via the queue into master with commit 8790abd Sep 30, 2024
7 of 8 checks passed
@RReverser RReverser deleted the ingvar/csharp-volatile-experimental branch September 30, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break A PR that breaks some user-visible API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants