Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RowSizeHint::index_to_range #1785

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Fix RowSizeHint::index_to_range #1785

merged 2 commits into from
Oct 1, 2024

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Oct 1, 2024

Description of Changes

Make sure index_to_range doesn't advance beyond rows_data.

@Centril Centril enabled auto-merge October 1, 2024 20:50
@bfops
Copy link
Collaborator

bfops commented Oct 1, 2024

This fixes an issue originally introduced in #1761.

bfops
bfops approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have all the context for this change, but this looks like a generally correct end condition check fix for an iterator, and I've confirmed it fixes at least one bug that was causing crashes.

@Centril Centril added this pull request to the merge queue Oct 1, 2024
Merged via the queue into master with commit cb13f10 Oct 1, 2024
8 of 9 checks passed
@Centril Centril deleted the centril/fix-websocket-api branch October 1, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfops bfops bfops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Centril @bfops