Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build: Use default() to init custom hash based datastructures #1871

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

Shubham8287
Copy link
Contributor

@Shubham8287 Shubham8287 commented Oct 17, 2024

Description of Changes

hashbrown updated their default hasher - https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md#v0150---2024-10-01.
Which is conflicting with DefaultHashBuilder in our custom types.

start initialising using ::default() to fix this.

API and ABI breaking changes

N/A

Expected complexity level and risk

1

Testing

Successful compiling should be enough.

  • Write a test you've completed here.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

@Shubham8287 Shubham8287 changed the title Use default() to init custom hashmap Use default() to init custom hash based datastructures Oct 17, 2024
@Shubham8287 Shubham8287 changed the title Use default() to init custom hash based datastructures Fix Build: Use default() to init custom hash based datastructures Oct 17, 2024
@Centril

This comment was marked as resolved.

crates/durability/src/lib.rs Outdated Show resolved Hide resolved
crates/table/src/table.rs Show resolved Hide resolved
Cargo.lock Show resolved Hide resolved
Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com>
Signed-off-by: Shubham Mishra <shubham@clockworklabs.io>
@Shubham8287 Shubham8287 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into master with commit 0a86b46 Oct 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants