Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrimaryKey implementation should use client side indexes #2113

Open
bfops opened this issue Jan 13, 2025 · 1 comment
Open

PrimaryKey implementation should use client side indexes #2113

bfops opened this issue Jan 13, 2025 · 1 comment

Comments

@bfops
Copy link
Collaborator

bfops commented Jan 13, 2025

Right now clients determine if rows match by calling a primary key compare func which just compares values in AlgebraicValue. Once we have client side indexes, we should just lookup the new value using the index to determine whether or not the current insert was an update.

Done for C# but not Typescript, Rust, Python

@bfops
Copy link
Collaborator Author

bfops commented Jan 13, 2025

I think we may have other tickets for this? I think we've worked on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant