Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid cookies should not cause a server error #2115

Open
bfops opened this issue Jan 13, 2025 · 3 comments
Open

Invalid cookies should not cause a server error #2115

bfops opened this issue Jan 13, 2025 · 3 comments
Assignees
@cloutiertyler

Comments

@bfops
Copy link
Collaborator

bfops commented Jan 13, 2025 •
edited
Loading

Update the cookie processing for the session so that invalid cookies do not cause a server error. A bad session cookie should be detected and discarded.

This is possibly a P2 since it only happens if someone deliberately sets invalid cookies, we issue invalid cookies, or we wipe the database (which should not happen).
@bfops
Copy link
Collaborator Author

bfops commented Jan 13, 2025

Adding this to 1.0 since it was created recently.

@bfops
Copy link
Collaborator Author

bfops commented Jan 13, 2025

Does this just cause an error log, or does it negatively impact the server?

@bfops bfops changed the title Update the cookie processing for the session so that invalid cookies do not cause a server error. A bad session cookie should be detected and discarded. Update the cookie processing for the session so that invalid cookies do not cause a server error Jan 13, 2025
@bfops bfops changed the title Update the cookie processing for the session so that invalid cookies do not cause a server error Invalid cookies should not cause a server error Jan 13, 2025
@bfops
Copy link
Collaborator Author

bfops commented Jan 13, 2025

This does not only happen for malicious users; it could happen if we wipe the server data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cloutiertyler cloutiertyler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bfops @cloutiertyler